Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jbl/codecov #66

Merged
merged 15 commits into from
Oct 13, 2023
Merged

Jbl/codecov #66

merged 15 commits into from
Oct 13, 2023

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Sep 14, 2023 •
edited
Loading

Description

Exclude some third party-code (pugixml) from code-coverage analysis, to have a more realistic coverage assessment.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

by running Github-CI/CD-test

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #66 (592ad85) into main (c9954d5) will increase coverage by 12.95%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #66       +/-   ##
===========================================
+ Coverage   50.29%   63.25%   +12.95%     
===========================================
  Files          78       76        -2     
  Lines       16116    10098     -6018     
===========================================
- Hits         8105     6387     -1718     
+ Misses       8011     3711     -4300
Flag Coverage Δ
windows-latest 63.25% <ø> (+12.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ptahmose ptahmose marked this pull request as ready for review September 15, 2023 23:28
@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Sep 15, 2023
@FelixS90 FelixS90 merged commit f18a030 into ZEISS:main Oct 13, 2023
15 of 16 checks passed
@ptahmose ptahmose deleted the jbl/codecov branch October 13, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ringler m-ringler m-ringler approved these changes

@FelixS90 FelixS90 FelixS90 approved these changes

@soyers soyers Awaiting requested review from soyers

Assignees
No one assigned
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptahmose @FelixS90 @m-ringler